Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Bootstrap theme to modern syntax #5191

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Conversation

inikolova
Copy link
Contributor

@inikolova inikolova commented Oct 14, 2024

@inikolova inikolova force-pushed the bootstrap-dart branch 3 times, most recently from 4fbb88d to 3ac05af Compare October 14, 2024 15:58
@zhpenkov zhpenkov changed the base branch from develop to core-utils-dart October 15, 2024 07:24
@inikolova inikolova force-pushed the bootstrap-dart branch 3 times, most recently from bf917d8 to e02cc10 Compare October 17, 2024 11:57
@epetrow epetrow force-pushed the core-utils-dart branch 8 times, most recently from a7cb324 to 6580397 Compare October 18, 2024 07:11
@inikolova inikolova force-pushed the bootstrap-dart branch 11 times, most recently from 83b9fee to 67060c6 Compare October 22, 2024 13:25
@inikolova inikolova force-pushed the bootstrap-dart branch 2 times, most recently from d7a1237 to 96e40d0 Compare October 31, 2024 08:45
Copy link
Contributor

@silviyaboteva silviyaboteva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great output! 👏🏻❤️

I only suggest to fixup the commits a bit :)

Copy link
Contributor

@zhpenkov zhpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@inikolova inikolova force-pushed the bootstrap-dart branch 4 times, most recently from 03c4b21 to be315c1 Compare October 31, 2024 14:58
BREAKING CHANGE

Starting with the R4 2024 release, all Kendo themes are now migrated to
the SASS module system. This breaking change is due to the `node-sass`
package reaching its official end of life.

For more information, please refer to the following links:

* https://sass-lang.com/blog/the-module-system-is-launched/
* sass/node-sass@107ded9
BREAKING CHANGE: Effective with the R4 2024 release, twbs/bootstrap is
removed as a dependency of the Kendo UI Bootstrap theme. This means that
 customizing bootstrap scss variables will no longer have an effect on
our components, as the theme will be detached i.e. not depending upon.
However, we will provide mostly the same look and feel through variables
 that have the same values.

In order to continue using twbs/bootstrap along with the Kendo Bootstrap
 theme, make sure to add a it as a dependency to your project.
@inikolova inikolova merged commit decb5e4 into core-utils-dart Oct 31, 2024
19 checks passed
@inikolova inikolova deleted the bootstrap-dart branch October 31, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Item which is introducing a breaking change. T:Bootstrap Kendo Theme Bootstrap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants